chore: Integration/prisma/engines#3942
Conversation
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
| @@ -1,122 +0,0 @@ | |||
| const { download } = require('@prisma/fetch-engine') | |||
There was a problem hiding this comment.
Looks like this went to https://github.com/prisma/engines-wrapper/blob/master/packages/engines/src/download.ts
Jolg42
left a comment
There was a problem hiding this comment.
Looks like tests for https://github.com/prisma/engines-wrapper/blob/master/packages/engines/src/__tests__/all-exist.test.ts state is "TODO" 😄
| path.join(__dirname, '../query-engine-darwin') | ||
| path.join(__dirname, '../introspection-engine-darwin') | ||
| path.join(__dirname, '../prisma-fmt-darwin') | ||
| // commented out, as these paths are different now with @prisma/engines |
There was a problem hiding this comment.
Because they might be needed, so I want to keep the hints for now.
We'll see in the e2e tests if they're needed.
Jolg42
left a comment
There was a problem hiding this comment.
Nice!!
Could you update this https://github.com/prisma/prisma/blob/master/src/package.json#L32 and remove download-all?
That is correct :) |
Closes #3928