You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think specifying type: commonjs is totally valid and helps in environment like deno.
To me it seems like it is an issue with Next.js if packages that correctly specify type: commonjs (prisma is a CJS package) no longer work.
This should have been fixed in Next.js rather than reverting a valid change in prisma.
Reverting this change just supports Next.js and their invalid handling of different package formats.
You both are right and I share the sentiment, but our goal is to not break the majority of our users, and realistically we have significantly more Next.js users. This is absolutely a bug that needs to be fixed upstream and it's unfortunate that we had to revert this to work around it (thus inconveniencing Deno users again), but we have to be pragmatic. If the breakage was introduced by a sudden change in Next.js without any changes on our side, then the considerations could have been different. Sorry for this, I understand that it is frustrating to you. We'll find a way forward.
@dodas@P4sca1 you're absolutely right, I'm pushing the issue forward on with the Next.js team, once it's resolved upstream will ping the Prisma team, even I'll introduce the cjs change again to get this resolved asap!
@semoal is there a tracking ticket or PR for this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #25734 as discussed to fix #25761.