Skip to content

fix: Specify 'type': 'commonjs' in generated client package.json#25734

Merged
aqrln merged 2 commits intoprisma:mainfrom
bartlomieju:generated_client_pkg_json_type
Nov 27, 2024
Merged

fix: Specify 'type': 'commonjs' in generated client package.json#25734
aqrln merged 2 commits intoprisma:mainfrom
bartlomieju:generated_client_pkg_json_type

Conversation

@bartlomieju
Copy link
Copy Markdown
Contributor

This commit changes the generated client's "package.json"
file to include "type": "commonjs".

While in Node.js lack of "type" field implies CommonJS,
in Deno it defaults to ESM. This change will help fix
denoland/deno#27079 and is completely
backwards compatible.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 27, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 27, 2024

CodSpeed Performance Report

Merging #25734 will not alter performance

Comparing bartlomieju:generated_client_pkg_json_type (3af95c6) with main (5e39f28)

Summary

✅ 3 untouched benchmarks

@aqrln aqrln added this to the 6.0.0 milestone Nov 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 27, 2024
@aqrln aqrln merged commit 914f1b3 into prisma:main Nov 27, 2024
@bartlomieju bartlomieju deleted the generated_client_pkg_json_type branch November 28, 2024 02:21
@bartlomieju
Copy link
Copy Markdown
Contributor Author

Thanks for a quick merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants