fix(instrumentation): do not pin OTEL dependencies#23019
Closed
maxkomarychev wants to merge 2 commits intoprisma:mainfrom
Closed
fix(instrumentation): do not pin OTEL dependencies#23019maxkomarychev wants to merge 2 commits intoprisma:mainfrom
maxkomarychev wants to merge 2 commits intoprisma:mainfrom
Conversation
3cb2f60 to
9255661
Compare
9255661 to
579e0e0
Compare
maxkomarychev
added a commit
to maxkomarychev/prisma
that referenced
this pull request
Feb 8, 2024
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
maxkomarychev
added a commit
to maxkomarychev/prisma
that referenced
this pull request
Feb 8, 2024
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
579e0e0 to
fa528be
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Jolg42
reviewed
Mar 6, 2024
d731526 to
cd6732e
Compare
Contributor
Author
|
Dear prisma maintainers, could you please provide specific feedback regarding prospects of this being merged? Are you willing to accept this pr, should I keep keeping it up to date etc? |
aqrln
approved these changes
Apr 9, 2024
Member
aqrln
left a comment
There was a problem hiding this comment.
Sorry for the delay here — let's finally ship this
Member
|
I think this may also need some adjustments in the Renovate config to avoid the versions being automatically pinned. |
Fixes issues with telemetry prisma#21473 by using non-pinned versions of OTEL libraries. Fixes prisma#21473
cd6732e to
fa60c68
Compare
Jolg42
added a commit
that referenced
this pull request
Apr 25, 2024
See original PR #23019 Co-authored-by: Max Komarychev <maxkomarychev@gmail.com>
Contributor
|
Note: Closing this and replacing it with #23971 because we are missing rights to edit the PR. |
Contributor
Author
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues with telemetry #21473 by using non-pinned versions of OTEL libraries.
Fixes #21473