-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fixed version of @opentelemetry/* dependencies #21473
Copy link
Copy link
Closed
Labels
bug/2-confirmedBug has been reproduced and confirmed.Bug has been reproduced and confirmed.kind/bugA reported bug.A reported bug.topic: prisma-clienttopic: tracing
Milestone
Description
Bug description
Currently prisms locks versions of OTEL libraries:
"@opentelemetry/api": "1.6.0",
"@opentelemetry/instrumentation": "0.43.0",
"@opentelemetry/sdk-trace-base": "1.17.0",This creates problem with hoisting: if there are other versions of OTEL libs required in the project package manager will end up installing two copies of "@opentelemetry/api" in order to satisfy constraints:
- one in root
node_modules - second one in
node_modules/<another_package>/node_modules
This will make either external or internal consumers of prisma to receive no-op implementation of a tracer.
How to reproduce
Expected behavior
A package should keep versions of it's dependencies as open as possible https://github.com/prisma/prisma/blob/811babfebbd8c573109f0dc083634bc2e865a87e/packages/instrumentation/package.json
Prisma information
// Add your schema.prisma// Add your code using Prisma ClientEnvironment & setup
- OS:
- Database:
- Node.js version:
Prisma Version
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bug/2-confirmedBug has been reproduced and confirmed.Bug has been reproduced and confirmed.kind/bugA reported bug.A reported bug.topic: prisma-clienttopic: tracing