Skip to content

Followup work on setup github actions#7431

Merged
thorn0 merged 37 commits intoprettier:masterfrom
fisker:adjust-github-actions
Mar 23, 2020
Merged

Followup work on setup github actions#7431
thorn0 merged 37 commits intoprettier:masterfrom
fisker:adjust-github-actions

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Jan 25, 2020 •
edited
Loading

@fisker fisker force-pushed the adjust-github-actions branch from 8cb5fd6 to 1ce0209 Compare January 25, 2020 16:09
@fisker fisker force-pushed the adjust-github-actions branch from 1ce0209 to 412bb10 Compare January 25, 2020 16:15
@fisker

This comment has been minimized.

Sign in to view
@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 25, 2020

Let's start removing the common ones..

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 25, 2020

@lipis You mean azure pipelines?

@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 25, 2020

Yes

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 25, 2020

How about remove it in a separate PR?
Do we need keep both for a while?

@fisker fisker force-pushed the adjust-github-actions branch from 89c0325 to 0e65dbf Compare January 25, 2020 17:13
@fisker fisker force-pushed the adjust-github-actions branch from 0e65dbf to 254278e Compare January 25, 2020 17:14
@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 25, 2020

Yes maybe.. let's finalize the gh ones..

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 25, 2020 •
edited
Loading

@lipis Please add a CODECOV_TOKEN

@fisker fisker force-pushed the adjust-github-actions branch from 33e680e to b410b12 Compare January 25, 2020 18:30
@fisker fisker force-pushed the adjust-github-actions branch 5 times, most recently from 7d88632 to a3d7b80 Compare January 25, 2020 19:30
@fisker fisker force-pushed the adjust-github-actions branch from 46c4b61 to 877814c Compare March 19, 2020 01:57
@fisker fisker force-pushed the adjust-github-actions branch from 877814c to e13fc68 Compare March 19, 2020 02:24
@lipis
Copy link
Copy Markdown
Member

lipis commented Mar 19, 2020

All green! That means we are ready to get rid of Azure? or they are still doing something more than we do with GitHub?

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Mar 19, 2020 •
edited
Loading

@lipis All azure jobs covered, problem is github actions seems slower than azure, especially the one collects coverage.

@lipis
Copy link
Copy Markdown
Member

lipis commented Mar 21, 2020

I would still go with GitHub...

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Mar 21, 2020

I use github actions too.

Seems faster with --maxWorkers, 20mins vs 15mins, should be acceptable

@thorn0 thorn0 changed the base branch from next to master March 21, 2020 21:02
@lipis
Copy link
Copy Markdown
Member

lipis commented Mar 21, 2020

Let me know when we can disable Azure :)

@lipis
Copy link
Copy Markdown
Member

lipis commented Mar 21, 2020

Just remove the .azure directory and we should be fine when you're ready.

@fisker fisker mentioned this pull request Mar 22, 2020
Merged
4 tasks
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Mar 22, 2020

Let's disable it in #7824 , shall we?

@thorn0 thorn0 merged commit 54f907d into prettier:master Mar 23, 2020
@fisker fisker deleted the adjust-github-actions branch March 23, 2020 04:42
@thorn0 thorn0 mentioned this pull request Mar 23, 2020
Merged
3 tasks
thorn0
thorn0 reviewed Mar 24, 2020
View reviewed changes
jest.config.js
"jest-watch-typeahead/testname",
],
reporters: ["default"].concat(ENABLE_TEST_RESULTS ? "jest-junit" : []),
verbose: true,
Copy link
Copy Markdown
Member

@thorn0 thorn0 Mar 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove this verbose: true? Now Jest prints too much when I run it locally.

Copy link
Copy Markdown
Member Author

@fisker fisker Mar 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about set to isCI, yarn test will print less, and yarn test --verbose can still print more

Copy link
Copy Markdown
Member Author

@fisker fisker Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7866

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thorn0 thorn0 thorn0 approved these changes

@lipis lipis lipis approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fisker @lipis @armano2 @thorn0 @sosukesuzuki