Skip to content

Setup github actions#7321

Merged
lipis merged 4 commits intoprettier:nextfrom
fisker:git-actions
Jan 25, 2020
Merged

Setup github actions#7321
lipis merged 4 commits intoprettier:nextfrom
fisker:git-actions

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Jan 14, 2020 •
edited
Loading

Github Actions Build Status Github Actions Build Status Github Actions Build Status
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker force-pushed the git-actions branch 4 times, most recently from 5663930 to 8814930 Compare January 14, 2020 09:37
@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 20, 2020

#7401

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 20, 2020

I setup this for test , seems not too much difference on speed.

https://github.com/fisker/prettier/actions

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 20, 2020

Also it's not running on this PR, is it because the org account has no actions permission?

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 23, 2020

Anyone know how to make this run?

@lipis lipis marked this pull request as ready for review January 24, 2020 01:09
lipis
lipis reviewed Jan 24, 2020
View reviewed changes
lipis
lipis reviewed Jan 24, 2020
View reviewed changes
@fisker fisker changed the title Setup github actions CI Setup github actions Jan 24, 2020
lipis
lipis reviewed Jan 25, 2020
View reviewed changes
.github/workflows/dev-test.yml
@@ -0,0 +1,36 @@
name: Dev_Test

on: [pull_request]
Copy link
Copy Markdown
Member

@lipis lipis Jan 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe on [push]?

I'm runnuing out of ideas.. maybe we can merge it and see what happens.

@lipis lipis merged commit 93f71d4 into prettier:next Jan 25, 2020
@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 25, 2020

Merged it, so maybe it will trigger them.. if it works let's start adjusting those.

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 25, 2020

Great, running

@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 25, 2020

Now let's optimize them and move more here.. and start removing the duplicate ones...

@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 27, 2020

I just noticed that we did that on next branch... why not on master?

@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 27, 2020

Can you create a new PR for master and sync next afterwards?

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Jan 27, 2020

Scripts are different from master and next, why waste time write actions config for old scripts?

@lipis
Copy link
Copy Markdown
Member

lipis commented Jan 27, 2020

fair enough... we should soon be done with 2.0 anyways.

@fisker fisker deleted the git-actions branch January 27, 2020 18:30
@fisker fisker mentioned this pull request Feb 14, 2020
Merged
3 tasks
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label May 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lipis lipis lipis left review comments

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @lipis