Skip to content

Tweak test and CI configs#7866

Merged
thorn0 merged 4 commits intoprettier:masterfrom
fisker:tweak-tests
Mar 26, 2020
Merged

Tweak test and CI configs#7866
thorn0 merged 4 commits intoprettier:masterfrom
fisker:tweak-tests

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Mar 25, 2020

  • Set jest verbose to false by default
  • Correct doc-debug.js path
  • Remove outdated ignore patterns
  • Exclude Node.js 13 on macos

✨Try the playground for this PR✨

@fisker fisker mentioned this pull request Mar 25, 2020
Merged
3 tasks
@fisker fisker changed the title Tweak tests and CI configs Tweak test and CI configs Mar 25, 2020
thorn0
thorn0 reviewed Mar 25, 2020
View reviewed changes
.github/workflows/dev-test.yml
ENABLE_CODE_COVERAGE: true
exclude:
- os: "macos-latest"
node: "13"
Copy link
Copy Markdown
Member

@thorn0 thorn0 Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you exclude it simply because macos tests take longer and are flakier or is there something else?

Copy link
Copy Markdown
Member Author

@fisker fisker Mar 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github Actions limit Maximum concurrent macOS jobs to 5, https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits . I think we should use less macOS jobs.

@thorn0 thorn0 merged commit 412694e into prettier:master Mar 26, 2020
@fisker fisker deleted the tweak-tests branch March 26, 2020 15:12
@thorn0
Copy link
Copy Markdown
Member

thorn0 commented Mar 28, 2020

Why do we need verbose: true at all, even on CI? Won't the tests run faster without it?

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Mar 30, 2020 •
edited
Loading

I don't think this will slow down the tests, and I think printing more information is very useful for new contributors.

@thorn0
Copy link
Copy Markdown
Member

thorn0 commented Mar 30, 2020

The log of a test run now has almost 20000 lines. Scrolling it in the browser is painful, especially on mobile. Is there a way probably to keep the benefits that verbose gives us without printing the names of individual tests? It's those names that make the log so big.

@fisker fisker mentioned this pull request Apr 1, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thorn0 thorn0 thorn0 approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fisker @thorn0 @sosukesuzuki