Merged
Conversation
Member
|
good job, need look what is problem with CI |
Member
Author
|
what is the problem could be |
# Conflicts: # yarn.lock
Member
Author
|
strange thing, |
Member
Author
|
Should be a |
597c244 to
4fdc9ba
Compare
fisker
commented
Nov 18, 2019
# Conflicts: # yarn.lock
Member
Author
|
merge? |
alexander-akait
approved these changes
Nov 18, 2019
thorn0
reviewed
Nov 18, 2019
| @@ -40,11 +41,13 @@ function runPrettierWithLogLevel(logLevel, patterns) { | |||
|
|
|||
| expect(result).not.toEqual(0); | |||
Member
There was a problem hiding this comment.
Suggested change
| expect(result).not.toEqual(0); | |
| expect(result.status).not.toEqual(0); |
While you're at it, could you also fix this?
Contributor
There was a problem hiding this comment.
drive-by comment: should probably not be negated at all to assert on the actual value instead of what it's not to avoid false negatives such as this.
Member
Author
There was a problem hiding this comment.
I'm going to change it to
expect(result.status).toEqual(2);
lydell
approved these changes
Nov 18, 2019
thorn0
approved these changes
Nov 19, 2019
lipis
added a commit
that referenced
this pull request
Jan 8, 2020
* 'next' of github.com:prettier/prettier: Optimize some usage of `Array#filter` (#6996) Update `jest` to v24 (#6954) Replace `trim{Left,Right}` with `trim{Start,End}` (#6994) Set `trailingComma` default value to `es5` (#6963) Fix `new` usage for builtin objects (#6968) Replace `indexOf` with `includes` (#6967) fix: tests for empty type parameters in TS (#6960) Fix MDX html parsing errors (#6949) fix: issue #6813 (Zero-based lists are broken) (#6852) Style: use async functions (#6935) Disable trailingComma for Angular internal parser (#6912) Update `snapshot-diff` to v0.6.1 (#6955) Update build scripts to target Node.js 10 (#6908)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #6928
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨