Skip to content

Update build scripts to target Node.js 10#6908

Merged
lydell merged 6 commits intoprettier:nextfrom
fisker:build-target-10
Nov 13, 2019
Merged

Update build scripts to target Node.js 10#6908
lydell merged 6 commits intoprettier:nextfrom
fisker:build-target-10

Conversation

@fisker
Copy link
Copy Markdown
Member

@fisker fisker commented Nov 10, 2019

follows #6907

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker changed the title Update build scripts target Node 10 Update build scripts to target Node 10 Nov 10, 2019
@fisker fisker changed the title Update build scripts to target Node 10 Update build scripts to target Node.js 10 Nov 10, 2019
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 10, 2019 •
edited
Loading

here, another problem, netlify deploy running on 8, I didn't saw a config file, is it on their site? @j-f1

@fisker fisker changed the base branch from master to next November 10, 2019 19:31
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 12, 2019

netlify not running

@fisker fisker mentioned this pull request Nov 12, 2019
Merged
4 tasks
@j-f1
Copy link
Copy Markdown
Member

j-f1 commented Nov 12, 2019

https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript

@fisker fisker changed the base branch from next to master November 12, 2019 06:03
@fisker fisker changed the base branch from master to next November 12, 2019 06:14
@fisker fisker changed the base branch from next to master November 12, 2019 06:15
@fisker fisker changed the base branch from master to next November 12, 2019 06:39
lydell
lydell reviewed Nov 12, 2019
View reviewed changes
@alexander-akait
Copy link
Copy Markdown
Member

alexander-akait commented Nov 13, 2019

/cc @prettier/core

@lydell lydell merged commit e44c360 into prettier:next Nov 13, 2019
@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 13, 2019

@lydell removing this will break netlify deploy

@fisker fisker deleted the build-target-10 branch November 14, 2019 00:53
@lydell
Copy link
Copy Markdown
Member

lydell commented Nov 14, 2019

Can’t we fix netlify deploy some other way?

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 14, 2019

I'm not sure, is there any settings in netlify site?

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 14, 2019 •
edited
Loading

I checked my netlify account, on settings page

Environment section , maybe we can set NODE_VERSION to 10 or 12

but in Deploy contexts section, it seems only one branch is allowed

@fisker
Copy link
Copy Markdown
Member Author

fisker commented Nov 15, 2019

Someone taking care of this?

/cc @prettier/core

@j-f1
Copy link
Copy Markdown
Member

j-f1 commented Nov 17, 2019

@azz is the owner of the Prettier site on Netlify.

If you have the time, could you email Netlify support and ask them to create an OSS team for us so all the core maintainers can access the site settings @azz?

sosukesuzuki pushed a commit to sosukesuzuki/prettier that referenced this pull request Jan 2, 2020
@fisker @sosukesuzuki
Update build scripts to target Node.js 10 (prettier#6908)
98e7477
lipis added a commit that referenced this pull request Jan 8, 2020
@lipis
Merge branch 'next' of github.com:prettier/prettier into next
ac6c6fa 
* 'next' of github.com:prettier/prettier:
  Optimize some usage of `Array#filter` (#6996)
  Update `jest` to v24 (#6954)
  Replace `trim{Left,Right}` with `trim{Start,End}` (#6994)
  Set `trailingComma` default value to `es5` (#6963)
  Fix `new` usage for builtin objects (#6968)
  Replace `indexOf` with `includes` (#6967)
  fix: tests for empty type parameters in TS (#6960)
  Fix MDX html parsing errors (#6949)
  fix: issue #6813 (Zero-based lists are broken) (#6852)
  Style: use async functions (#6935)
  Disable trailingComma for Angular internal parser (#6912)
  Update `snapshot-diff` to v0.6.1 (#6955)
  Update build scripts to target Node.js 10 (#6908)
@sosukesuzuki sosukesuzuki mentioned this pull request Jan 22, 2020
Closed
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Feb 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lydell lydell lydell approved these changes

@j-f1 j-f1 j-f1 left review comments

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees

No one assigned

Labels

locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fisker @j-f1 @alexander-akait @lydell