Merged
Conversation
Member
|
Could you add the test case from the issue as well? Available here: master...lydell:jsx-nbsp-test |
I don't know why I added all the unicode whitespaces instead of just space and tabs, but it's not only unecessary but also wrong. Fixes prettier#5077
e99bea0 to
18faf56
Compare
Contributor
Author
|
Done |
lydell
approved these changes
Sep 29, 2018
Member
lydell
left a comment
There was a problem hiding this comment.
Nice!
I checked out your branch locally and verified that the test snapshots contain actual non-breaking spaces.
1 task
ikatyang
added a commit
that referenced
this pull request
Nov 4, 2018
The issue here is that less parser somehow included CRs in `comment.raws.content`, but it was hidden by the wrong trailing space elimination previously, which was fixed by #5165. We already have such tests but it's not reproducible in AppVeyor since they use LF ([`core.autocrlf=input`](https://stackoverflow.com/a/20653073)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why I added all the unicode whitespaces instead of just space and tabs. It's not only unnecessary but also wrong.
It is preserved in the output
Fixes #5077