fix(less): remove CRs from inline comments#5334
Merged
ikatyang merged 1 commit intoprettier:masterfrom Nov 4, 2018
Merged
Conversation
lydell
approved these changes
Nov 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5315
The issue is that less parser somehow included CRs in
comment.raws.content, but it was hidden by the wrong trailing space elimination previously, which was fixed by #5165.I’ve added tests to confirm my change works.We already have such tests but it's not reproducible in AppVeyor since they use LF (
core.autocrlf=input).docs/directory)