Handle rediscluster temporarily unavailable #731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authentication for sentinels was implemented in v1.1.5 (commit 2e76410) but ended up being bugged (see ISSUE predis#658). This is now postponed as it requires a more thorough investigation.
Removed is_resource() check as socket_create() now returns an object.
When using the phpiredis-based connection backends, failed pipelines led to spurious responses returned after reconnecting to Redis because the underlying reader was not properly reset by discarding buffered replies after disconnecting. Fixes a couple of issues reported in predis#363.
The patches to get PHPUnit working are causing problems for other projects that use both `cweagans/composer-patch-installers` and `predis/predis` along with PHPUnit. This change moves the patch application to a simple PHP script run on the `post-update-cmd` composer event and removes the dependency on the patch installers package.
Apply patches on initial install/update
Add some return types
$this->retryWait is in milliseconds. It's setter misleadingly document it as seconds. Fixing by renaming the argument variable name without altering the functionality.
Fix misleading argument name in SentinelReplication
fix test expectation for redis 6.2
For some reason Xdebug causes a seg fault under PHP 8 on Travis CI.
* Add PHP 8.1 support * Update AbortedMultiExecException.php * Update CommunicationException.php * Update ServerSentinel.php * Update CursorBasedIterator.php * Update ReplicationStrategy.php Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
seemingly no docs on this...
* Fix PHP 8.1 strlen breakage This adds a fallback to an empty string if the argument is `null` for some reason. * Update StreamConnection.php * use `strval()` Co-authored-by: Till Krüss <tillkruss@users.noreply.github.com>
…onnection\Aggregate\RedisCluster)
|
Something if off with the PR, like merging the wrong version into the branch. Yours is the last commit only, but it seems 30 other commits joined yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes are trying to complete the retry logic in order to increase the tolerance to a temporary unavailability of a redis cluster.