Add PHP 8.1 support #712

javer · 2021-09-11T21:19:51Z

No description provided.

tillkruss · 2021-09-12T15:06:32Z

Thanks for submitting this. Can you please post the errors/deprecations you're seeing when running the current release in 8.1?

javer · 2021-09-12T16:44:49Z

src/Collection/Iterator/CursorBasedIterator.php

        $options = array();

-        if (strlen($this->match) > 0) {
+        if ($this->match !== null && strlen($this->match) > 0) {


Reason:

strlen(): Passing null to parameter #1 ($string) of type string is deprecated

javer · 2021-09-12T16:46:18Z

src/Collection/Iterator/ListKey.php

+    #[\ReturnTypeWillChange]
    public function rewind()


Reason for this and the following changes:

Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Collection\Iterator\ListKey::current() should either be compatible with Iterator::current(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Collection\Iterator\ListKey::next() should either be compatible with Iterator::next(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Collection\Iterator\ListKey::key() should either be compatible with Iterator::key(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Collection\Iterator\ListKey::valid() should either be compatible with Iterator::valid(): bool, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Collection\Iterator\ListKey::rewind() should either be compatible with Iterator::rewind(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

javer · 2021-09-12T16:50:48Z

src/Command/Processor/ProcessorChain.php

+    #[\ReturnTypeWillChange]
    public function offsetExists($index)


Reason for this and the following changes:

Fatal error: During inheritance of ArrayAccess: Uncaught Return type of Predis\Command\Processor\ProcessorChain::offsetExists($index) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of ArrayAccess: Uncaught Return type of Predis\Command\Processor\ProcessorChain::offsetGet($index) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of ArrayAccess: Uncaught Return type of Predis\Command\Processor\ProcessorChain::offsetSet($index, $processor) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of ArrayAccess: Uncaught Return type of Predis\Command\Processor\ProcessorChain::offsetUnset($index) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

javer · 2021-09-12T16:51:22Z

src/Command/ServerSentinel.php

-        switch (strtolower($this->getArgument(0))) {
+        $argument = $this->getArgument(0);
+
+        switch (strtolower($argument !== null ? $argument : '')) {


Reason:

strtolower(): Passing null to parameter #1 ($string) of type string is deprecated

javer · 2021-09-12T16:52:01Z

src/CommunicationException.php

        \Exception $innerException = null
    ) {
-        parent::__construct($message, $code, $innerException);
+        parent::__construct($message !== null ? $message : '', $code !== null ? $code : 0, $innerException);


Reason:

Exception::__construct(): Passing null to parameter #1 ($message) of type string is deprecated Exception::__construct(): Passing null to parameter #2 ($code) of type int is deprecated

javer · 2021-09-12T16:56:08Z

src/PubSub/AbstractConsumer.php

+    #[\ReturnTypeWillChange]
    public function rewind()


Reason for this and the following changes:

Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\PubSub\AbstractConsumer::current() should either be compatible with Iterator::current(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\PubSub\AbstractConsumer::next() should either be compatible with Iterator::next(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\PubSub\AbstractConsumer::key() should either be compatible with Iterator::key(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\PubSub\AbstractConsumer::valid() should either be compatible with Iterator::valid(): bool, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\PubSub\AbstractConsumer::rewind() should either be compatible with Iterator::rewind(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

javer · 2021-09-12T16:57:05Z

src/Replication/ReplicationStrategy.php

-            $sha1 = $eval ? sha1($command->getArgument(0)) : $command->getArgument(0);
+            $argument = $command->getArgument(0);
+            $sha1 = $eval ? sha1($argument !== null ? $argument : '') : $argument;


Reason:

sha1(): Passing null to parameter #1 ($string) of type string is deprecated

javer · 2021-09-12T16:57:47Z

src/Response/Iterator/MultiBulkIterator.php

+    #[\ReturnTypeWillChange]
    public function rewind()


Reason for this and the following changes:

Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Response\Iterator\MultiBulkIterator::current() should either be compatible with Iterator::current(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Response\Iterator\MultiBulkIterator::next() should either be compatible with Iterator::next(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Response\Iterator\MultiBulkIterator::key() should either be compatible with Iterator::key(): mixed, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Response\Iterator\MultiBulkIterator::valid() should either be compatible with Iterator::valid(): bool, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Iterator: Uncaught Return type of Predis\Response\Iterator\MultiBulkIterator::rewind() should either be compatible with Iterator::rewind(): void, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice Fatal error: During inheritance of Countable: Uncaught Return type of Predis\Response\Iterator\MultiBulkIterator::count() should either be compatible with Countable::count(): int, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

javer · 2021-09-12T16:59:34Z

src/Response/Iterator/MultiBulkTuple.php

+    #[\ReturnTypeWillChange]
    public function getInnerIterator()


Reason:

Fatal error: During inheritance of OuterIterator: Uncaught Return type of Predis\Response\Iterator\MultiBulkTuple::getInnerIterator() should either be compatible with OuterIterator::getInnerIterator(): ?Iterator, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

javer · 2021-09-12T17:00:52Z

src/Transaction/AbortedMultiExecException.php

    public function __construct(MultiExec $transaction, $message, $code = null)
    {
-        parent::__construct($message, $code);
+        parent::__construct($message, $code !== null ? $code : 0);


Reason:

Exception::__construct(): Passing null to parameter #2 ($code) of type int is deprecated

Add PHP 8.1 support

4ef8378

javer commented Sep 12, 2021

View reviewed changes

tillkruss added 5 commits September 12, 2021 14:58

Update AbortedMultiExecException.php

252eb90

Update CommunicationException.php

155b90a

Update ServerSentinel.php

bc612db

Update CursorBasedIterator.php

ec80c50

Update ReplicationStrategy.php

3e24805

tillkruss merged commit 5004f5d into predis:v1.1 Sep 12, 2021

tillkruss mentioned this pull request Sep 29, 2021

The Future of Predis 🚀 #587

Closed

pimjansen mentioned this pull request Dec 8, 2021

PHP 8.1 support #727

Closed

pimjansen mentioned this pull request Dec 16, 2021

Fix for changing return types for PHP8.1 #730

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add PHP 8.1 support #712

Add PHP 8.1 support #712

Uh oh!

javer commented Sep 11, 2021

Uh oh!

tillkruss commented Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

javer Sep 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

		#[\ReturnTypeWillChange]
		public function offsetExists($index)

Uh oh!

Add PHP 8.1 support #712

Add PHP 8.1 support #712

Uh oh!

Conversation

javer commented Sep 11, 2021

Uh oh!

tillkruss commented Sep 12, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants