Apply patches on initial install/update #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patches to get PHPUnit working are causing problems for other projects that use both `cweagans/composer-patch-installers` and `predis/predis` along with PHPUnit. This change moves the patch application to a simple PHP script run on the `post-update-cmd` composer event and removes the dependency on the patch installers package.
Contributor
|
Thanks @roborourke, I'll give it a try this weekend! |
Author
|
Switched to old array syntax to support PHP 5.3 and fix the failing test there. |
Author
|
🤔 not sure why there's a failing test for PHP 5.3. Seems unrelated to this PR. Is that a known issue @nrk? |
Contributor
|
@roborourke yes it should be unrelated to your PR, I guess it's due to the change in ca468b7 but right now I'm not sure why it fails only when running on PHP 5.3. I'll check later, I'm rebuilding my VM with all of the binaries from PHP 5.3 up to 8.0 for a final check locally, targeting a new patch release this weekend. |
Author
|
Any luck with this on your end? |
Author
|
Anything I can do to help this along? |
Member
|
Related #679. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patches to get PHPUnit working are causing problems for other projects that use both
cweagans/composer-patchesandpredis/predisalong with PHPUnit.This change moves the patch application to a simple PHP script run on the
post-update-cmdcomposer event and removes the dependency on the patch installer package.Addresses #660