Skip to content

fix(i3): Deal with negative coordinates #2889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patrick96 merged 1 commit into from
Jan 5, 2023
Merged

fix(i3): Deal with negative coordinates #2889

patrick96 merged 1 commit into from
Jan 5, 2023

Conversation

@patrick96
Copy link
Member

@patrick96 patrick96 commented Jan 5, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Pulls in fix in i3ipcpp repo: polybar/i3ipcpp#12

Related Issues & Documents

Fixes #2888
Ref i3/i3#5352

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 added this to the 3.7.0 milestone Jan 5, 2023
@patrick96 patrick96 force-pushed the negative-rect-coords branch from 049e94e to 847482c Compare January 5, 2023 21:03
@patrick96 patrick96 merged commit fc423c0 into polybar:master Jan 5, 2023
@patrick96 patrick96 deleted the negative-rect-coords branch January 5, 2023 21:11
@patrick96 patrick96 mentioned this pull request Jan 5, 2023
Closed
5 tasks
rtucek added a commit to rtucek/dotfiles that referenced this pull request May 10, 2023
@rtucek
Fix issues with i3 gaps window indicator
20de329 
Enumerated windows aren't working properly due to negative i3-gaps value.

Issue discussed in
https://www.reddit.com/r/i3wm/comments/101wp5q/polybar_workspace_module_broken_after_move_from/,
which points to polybar/polybar#2888 with an
intermediate workaround in
polybar/polybar#2888 (comment).

Ultimately, the issue is fixed with
polybar/polybar#2889, however v3.7.0 is unreleased yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

[Bug]: module/i3 not updating workspace after update from i3-gaps to i3-wm 4.22

1 participant

@patrick96