Support negative rectangle coordinates #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since i3 4.22 now supports gaps, negative gaps can cause nodes (workspaces, windows, ...) to have negative coordinates which we did not support. However, sometimes i3 reports negative coordinates as `uint32_t`. Because of this the range of possible values for rectangle coordinates are `[INT32_MIN, UINT32_MAX)`. To work around this, we just read an int64_t. Ref: i3/i3#5352 Ref: polybar/polybar#2888
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Jan 5, 2023
Pulls in fix in i3ipcpp repo: polybar/i3ipcpp#12 Ref: polybar#2888 Ref: i3/i3#5352
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Jan 5, 2023
Pulls in fix in i3ipcpp repo: polybar/i3ipcpp#12 Fixes polybar#2888 Ref i3/i3#5352
9 tasks
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Jan 5, 2023
Pulls in fix in i3ipcpp repo: polybar/i3ipcpp#12 Fixes polybar#2888 Ref i3/i3#5352
patrick96
added a commit
to polybar/polybar
that referenced
this pull request
Jan 5, 2023
Pulls in fix in i3ipcpp repo: polybar/i3ipcpp#12 Fixes #2888 Ref i3/i3#5352
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since i3 4.22 now supports gaps, negative gaps can cause nodes (workspaces, windows, ...) to have negative coordinates which we did not support.
However, sometimes i3 reports negative coordinates as
uint32_t. Because of this the range of possible values for rectangle coordinates are[INT32_MIN, UINT32_MAX).To work around this, we just read an int64_t.
Ref: i3/i3#5352
Ref: polybar/polybar#2888