Skip to content

4557 ndc thread local#4674

Closed
aleks-f wants to merge 6 commits intomainfrom
4557-ndc-thread-local
Closed

4557 ndc thread local#4674
aleks-f wants to merge 6 commits intomainfrom
4557-ndc-thread-local

Conversation

@aleks-f
Copy link
Copy Markdown
Member

@aleks-f aleks-f commented Sep 11, 2024

replacement for #4667 , fixing #4557

@aleks-f
Copy link
Copy Markdown
Member Author

aleks-f commented Sep 11, 2024

@siren186 FWIW, there is also Linux backtrace implemented here that never made it to the release. Would be nice to add it, but I can't dedicate the time now

assertTrue (NDC::current().depth() == 1);
{
poco_ndc("item2");
poco_ndc("item2"); int line2 = __LINE__;

Check notice

Code scanning / CodeQL

Declaration hides variable

Variable _theNdcScope hides another variable of the same name (on [line 57](1)).
assertTrue (NDC::current().depth() == 2);
{
poco_ndc("item3");
poco_ndc("item3"); int line3 = __LINE__;

Check notice

Code scanning / CodeQL

Declaration hides variable

Variable _theNdcScope hides another variable of the same name (on [line 57](1)). Variable _theNdcScope hides another variable of the same name (on [line 60](2)).
@siren186
Copy link
Copy Markdown
Member

@aleks-f I don't have write access to your branch. I will create a new PR for this latter.

@siren186 siren186 mentioned this pull request Sep 12, 2024
@siren186
Copy link
Copy Markdown
Member

@aleks-f See my new PR: #4682

@aleks-f aleks-f closed this Sep 12, 2024
@matejk matejk deleted the 4557-ndc-thread-local branch March 15, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants