Skip to content

4557 ndc thread local#4682

Merged
aleks-f merged 9 commits intopocoproject:mainfrom
siren186:fix/NestedDiagnosticContext
Sep 12, 2024
Merged

4557 ndc thread local#4682
aleks-f merged 9 commits intopocoproject:mainfrom
siren186:fix/NestedDiagnosticContext

Conversation

@siren186
Copy link
Copy Markdown
Member

@siren186 siren186 commented Sep 12, 2024 •
edited
Loading

Replacement for PR: #4674

  1. Fix NestedDiagnosticContext should be thread local #4557
  2. Merged dump(bool nameOnly) function from implemented here
  3. Discard backtrace from implemented here . Because it can be replaced with a more powerful implementation by Boost.Stacktrace

@siren186 siren186 mentioned this pull request Sep 12, 2024
Closed
@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Sep 12, 2024

  1. Discard backtrace from implemented here . Because it can be replaced with a more powerful implementation by Boost.Stacktrace

Only if you plan to rewrite it in poco style; we will not introduce boost dependency

@siren186
Copy link
Copy Markdown
Member Author

siren186 commented Sep 12, 2024 •
edited
Loading

@aleks-f Rewrite boost::stacktrace in poco style is complex. I think current PR is not fit to solve the problem.
For me import both Boost and Poco in my application is a better chioce.
If there is a fate in the future, I will implement it and create another PR to solve the problem.

@aleks-f aleks-f merged commit 71a9bda into pocoproject:main Sep 12, 2024
@siren186 siren186 deleted the fix/NestedDiagnosticContext branch September 12, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NestedDiagnosticContext should be thread local

2 participants

@siren186 @aleks-f