fix(NestedDiagnosticContext): NDC crashed in multi-thread environment#4667
Closed
siren186 wants to merge 5 commits intopocoproject:mainfrom
siren186:fix/NestedDiagnosticContext
Closed
fix(NestedDiagnosticContext): NDC crashed in multi-thread environment#4667siren186 wants to merge 5 commits intopocoproject:mainfrom siren186:fix/NestedDiagnosticContext
siren186 wants to merge 5 commits intopocoproject:mainfrom
siren186:fix/NestedDiagnosticContext
Conversation
Member
siren186
commented
Sep 6, 2024
- Fix: NestedDiagnosticContext should be thread local #4557
- Add more test case for NDC
aleks-f
requested changes
Sep 10, 2024
Member
aleks-f
left a comment
There was a problem hiding this comment.
I'm not sure this is the solution to the problem
…rd thread_local so that objects can dtor when thread exit
Member
Author
|
@aleks-f I found that |
aleks-f
requested changes
Sep 11, 2024
| assertTrue (NDC::current().depth() == 3); | ||
| NDC::current().dump(std::cout); | ||
| std::ostringstream ostr; | ||
| NDC::current().dump(ostr); |
Member
There was a problem hiding this comment.
I guess it would make sense to verify here that the output is correct.
Closed
Member
|
replaced with #4674 to trigger all CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.