buildwin.ps1 script error building the x64 version of Poco by KevDi · Pull Request #3749 · pocoproject/poco

KevDi · 2022-08-14T12:23:58Z

If build x64 the scripts looks for the _x64.vcproj Files which no longer exists. By removing this the Build is possible.
If only the Build Tools for Visual Studio are available the script does not run because those are not recognized by the Select-VSSetupInstance Script.
Adding the parameter -product * also recognizes the Build Tools.

#3740

If build x64 the scripts looks for the _x64.vcproj Files which no longer exists. By removing this the Build is possible. If only the Build Tools for Visual Studio are available the script does not run because those are not recognized by the Select-VSSetupInstance Script. Adding the parameter `-product *` also recognizes the Build Tools.

buildwin.ps1

aleks-f · 2022-08-16T09:34:22Z

@KevDi can you also try to add a CI entry for this?
It would be another entry like this, just using the buildwin.ps1 script instead of cmake:

poco/.github/workflows/ci.yml

Lines 150 to 160 in be19dc4

    
             windows-2019-msvc-cmake: 
        
               runs-on: windows-2019 
        
               env: 
        
                 CPPUNIT_IGNORE: class CppUnit::TestCaller<class PathTest>.testFind,class CppUnit::TestCaller<class ICMPSocketTest>.testSendToReceiveFrom,class CppUnit::TestCaller<class ICMPClientTest>.testPing,class CppUnit::TestCaller<class ICMPClientTest>.testBigPing,class CppUnit::TestCaller<class ICMPSocketTest>.testMTU,class CppUnit::TestCaller<class HTTPSClientSessionTest>.testProxy,class CppUnit::TestCaller<class HTTPSStreamFactoryTest>.testProxy 
        
               steps: 
        
                 - uses: actions/checkout@v2 
        
                 - run: cmake -S. -Bcmake-build -DENABLE_NETSSL_WIN=ON -DENABLE_NETSSL=OFF -DENABLE_CRYPTO=OFF -DENABLE_JWT=OFF -DENABLE_DATA=ON -DENABLE_DATA_ODBC=ON -DENABLE_DATA_MYSQL=OFF -DENABLE_DATA_POSTGRESQL=OFF -DENABLE_TESTS=ON 
        
                 - run: cmake --build cmake-build --config Release 
        
                 - run: >- 
        
                     cd cmake-build; 
        
                     ctest --output-on-failure -E "(DataMySQL)|(DataODBC)|(Redis)|(MongoDB)" -C Release

KevDi · 2022-08-16T09:51:59Z

Ok i will try to add the entry

KevDi · 2022-08-16T12:08:31Z

@aleks-f i tried to add the CI Section but it seems on the Actions Job Run the -omit does not work as expected. If i run the same command on my local Windows System it works. But on the Github Actions it still tries to build the Crypto Library.

KevDi · 2022-08-17T07:52:38Z

@aleks-f i test it again with the Encodings Project and it seems like on the github actions the check does not work. On my local system the Projects are skipped. But in the github actions no project is skipped and i don't know why

fix omit array presence printout

…ps1_fix

KevDi · 2022-08-17T09:11:05Z

@aleks-f ok i solved that issue. It seems like in the github actions the split method should only take exactly one character. I changed it from .split(",;") to .split(",") and now the skipping of Projects works.
Should we keep the , or the ; as the seperator for the omit list? I would go with the ;because it is already mentioned in the help section.

…purposes.

Changed the Components Seperator to only accept the `;`

…ries

aleks-f · 2022-08-17T11:12:19Z

@aleks-f ok i solved that issue. It seems like in the github actions the split method should only take exactly one character. I changed it from .split(",;") to .split(",") and now the skipping of Projects works. Should we keep the , or the ; as the seperator for the omit list? I would go with the ;because it is already mentioned in the help section.

I'd go with , because it is more intuitive and in line with make build. just change the doc, no big deal

aleks-f · 2022-08-17T11:17:45Z

now you have some joy with VS2022. try to comment out other CI entries so that a push triggers run only of the entries you are working on, not the whole world

let's not goo too crazy with CI entries

buildwin.ps1 failed to build x64 #3740 If build x64 the scripts looks for the _x64.vcproj Files which no longer exists. By removing this the Build is possible. If only the Build Tools for Visual Studio are available the script does not run because those are not recognized by the Select-VSSetupInstance Script. Adding the parameter `-product *` also recognizes the Build Tools. * Removed unused Parameter `platformName` * Added New CI targets for building poco with the buildwin.ps1 script Co-authored-by: Jan Kevin Dick <Jan.Dick@de.bosch.com> Co-authored-by: Aleksandar Fabijanic <aleks-f@users.noreply.github.com>

aleks-f requested changes Aug 14, 2022

View reviewed changes

buildwin.ps1 Outdated Show resolved Hide resolved

Removed unused Parameter platformName

cd9b45d

aleks-f approved these changes Aug 16, 2022

View reviewed changes

aleks-f changed the title ~~Fix Error when building the x64 Version of Poco~~ buildwin.ps1 script error building the x64 version of Poco Aug 16, 2022

aleks-f added this to the Release 1.13.0 milestone Aug 16, 2022

KevDi added 4 commits August 16, 2022 12:35

Added New CI Target for building poco with the Buildwin Script

ff25640

Fixed wrong call to the buildwin.ps1 script

351f284

Fixed Missing Whitespace on the -vs Parameter

d781771

Changed ordering of the -omit Arguments

89f2cb0

KevDi added 3 commits August 16, 2022 14:15

Added Print Statement for the omit and Components

bf48c05

Added Additional Omit Project for testing

efb8847

Added Prints for the buildwin script

bec9e99

KevDi and others added 5 commits August 17, 2022 09:55

Added Prints for the buildwin script

b6ee9bf

Update buildwin.ps1

49739ee

fix omit array presence printout

Changed seperator for omit list from ; to ,.

d87cbd5

Merge remote-tracking branch 'origin/buildwin_ps1_fix' into buildwin_…

2a9e16b

…ps1_fix

Changed seperator for split method to be only ,.

25cc94d

KevDi added 4 commits August 17, 2022 11:16

Removed Encodings Library from omit list. Was there only for testing …

2457a93

…purposes.

Removed Print Statements added for debugging purpose.

4217c69

Changed the Components Seperator to only accept the `;`

Added Section for Building the Library as 32Bit.

f7e8de7

Added Build Section for vs170. Fixed wrong seperator for omit libra…

9bf3e59

…ries

Fixed missing change from windows2019 to windows2022

3028949

KevDi and others added 4 commits August 17, 2022 13:37

Changed seperator for the omit list from ; to ,

cb66a82

Testing Win32 Build with VS2022

73d2d36

Reenabled all the jobs again.

638e0de

comment VS 2022 32-bit

d521582

let's not goo too crazy with CI entries

aleks-f merged commit f02088d into pocoproject:devel Aug 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buildwin.ps1 script error building the x64 version of Poco#3749

buildwin.ps1 script error building the x64 version of Poco#3749
aleks-f merged 23 commits intopocoproject:develfrom
KevDi:buildwin_ps1_fix

KevDi commented Aug 14, 2022 •

edited

Loading

Uh oh!

Uh oh!

aleks-f commented Aug 16, 2022

Uh oh!

KevDi commented Aug 16, 2022

Uh oh!

KevDi commented Aug 16, 2022

Uh oh!

KevDi commented Aug 17, 2022

Uh oh!

KevDi commented Aug 17, 2022

Uh oh!

aleks-f commented Aug 17, 2022

Uh oh!

aleks-f commented Aug 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

KevDi commented Aug 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

aleks-f commented Aug 16, 2022

Uh oh!

KevDi commented Aug 16, 2022

Uh oh!

KevDi commented Aug 16, 2022

Uh oh!

KevDi commented Aug 17, 2022

Uh oh!

KevDi commented Aug 17, 2022

Uh oh!

aleks-f commented Aug 17, 2022

Uh oh!

aleks-f commented Aug 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

KevDi commented Aug 14, 2022 •

edited

Loading