buildwin.ps1 failed to build x64 #3740
Description
Describe the bug
Building the Poco Libraries with the buildWin.ps1 script failed if -platform x64 is used.
To Reproduce
This is the command that was used: .\BuildWin.ps1' -poco_base . -vs 160 -action build -linkmode shared -config both -platform x64 -samples -tests -omit 'Crypto;NetSSL_OpenSSL;Data/ODBC;Data/MySQL;Data/PostgreSQL;JWT;MongoDB'
Expected behavior
Complete build of the Poco Library.
Logs
This is the Output from the Command above:
VS160COMNTOOLS=C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\
**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.11.15
** Copyright (c) 2021 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'
Build configuration:
--------------------
Poco Base: .
Version: 160
Action: build
Link Mode: shared
Configuration: both
Platform: x64
Tests: True
Samples: True
Build Tool: msbuild
Omit: Crypto;NetSSL_OpenSSL;Data/ODBC;Data/MySQL;Data/PostgreSQL;JWT;MongoDB
OpenSSL: $poco_base\openssl
+------------------------------------------------------------------
| VS project .\CppUnit_x64_vs160.vcxproj not found, skipping.
+------------------------------------------------------------------
The Issue is that in the end of the Powershell Script these lines are executed:
if ($platform -eq 'x64') { $platformName = '_x64' }
elseif ($platform -eq 'WinCE') { $platformName = '_CE' }
If these two lines are commented out the build works without any problems.
It seems this is a left over from the time when there where different vcproj files for x64 and win32.
If you want i can create a PR and remove these two lines.
Please add relevant environment information:
- Windows 10 & Visual Studio 2019 Professional
- Poco Version 1.12.1