-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Closed
Labels
Milestone
Description
PR #4996 is incomplete! It is missing that PNG depends on ZLIB.
poco/dependencies/png/src/pngstruct.h
Line 30 in 4540bbf
| #include "zlib.h" |
Fix for dependencies/png/CMakeLists.txt: Insert the following after line
poco/dependencies/png/CMakeLists.txt
Line 35 in 4540bbf
| add_library(PNG::PNG ALIAS _BUNDLED_PNG) |
target_link_libraries(_BUNDLED_PNG PUBLIC "$<BUILD_LOCAL_INTERFACE:ZLIB::ZLIB>")
This means that HPDF must also depend on ZLIB, otherwise it will not work with object or static libraries.
Fix for dependencies/hpdf/CMakeLists.txt: Replace line
poco/dependencies/hpdf/CMakeLists.txt
Line 23 in 4540bbf
| target_link_libraries(_BUNDLED_HPDF PRIVATE "$<BUILD_LOCAL_INTERFACE:PNG::PNG>") |
by
target_link_libraries(_BUNDLED_HPDF PUBLIC "$<BUILD_LOCAL_INTERFACE:PNG::PNG>" "$<BUILD_LOCAL_INTERFACE:ZLIB::ZLIB>")
Fix for PDF/CMakeLists.txt: Replace line
Line 25 in 4540bbf
| target_link_libraries(PDF PRIVATE "$<BUILD_LOCAL_INTERFACE:PNG::PNG>") |
by
target_link_libraries(PDF PRIVATE "$<BUILD_LOCAL_INTERFACE:PNG::PNG>" "$<BUILD_LOCAL_INTERFACE:ZLIB::ZLIB>")
Reactions are currently unavailable