Build: Move external libraries to dependencies/ subdirectory#4996
Merged
Build: Move external libraries to dependencies/ subdirectory#4996
Conversation
74f9fc0 to
7180ea8
Compare
Contributor
Author
|
| if (POCO_UNBUNDLED) | ||
| target_link_libraries(_BUNDLED_HPDF PRIVATE PNG::PNG) | ||
| else() | ||
| target_link_libraries(_BUNDLED_HPDF PRIVATE "$<BUILD_LOCAL_INTERFACE:PNG::PNG>") |
Contributor
There was a problem hiding this comment.
Is there an alternate solution to the BUILD_LOCAL_INTERFACE generator expression here? I think it would be good if Poco kept the cmake minimum to 3.15, or at least not jumping all the way to 3.26.
Contributor
Author
There was a problem hiding this comment.
I was not able to find other solution that does not involve writing own custom CMake scripts. And CMake 3.26 is the first version that has clean solution to link private Poco library and not get undefined export errors.
7180ea8 to
45d697d
Compare
a9d28c6 to
fd0355f
Compare
408b829 to
ee88bae
Compare
ee88bae to
fd09da1
Compare
Contributor
Author
|
Replaced all Make and VS jobs in the CI with CMake. PR is ready to be merged. |
318f7da to
f5bcb66
Compare
matejk
added a commit
that referenced
this pull request
Oct 9, 2025
* chore(v8_double_conversion): Move files from Foundation to dependencies.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4358.
Source code of external libraries is moved to subdirectory
dependencieswhere each of the libraries has its own subdirectory.When creating a bundled build, a static library is created and then linked where appropriate. For unbundled builds system provided library is linked.
This mechanism allows cleaner separation of Poco and other code, easier upgrade and the possibility to have fine-grained bundled options per external library.