Skip to content

CMake: Add missing link libraries in dependencies (fix #5044).#5046

Merged
matejk merged 3 commits intomainfrom
5044-fix-externals-dependencies
Oct 15, 2025
Merged

CMake: Add missing link libraries in dependencies (fix #5044).#5046
matejk merged 3 commits intomainfrom
5044-fix-externals-dependencies

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Oct 14, 2025

Closes #5044

@matejk matejk changed the title fix(dependencies, CMake): Add missing link libraries in dependencies. CMake: Add missing link libraries in dependencies (fix #5044). Oct 14, 2025
@matejk matejk mentioned this pull request Oct 14, 2025
Closed
@matejk matejk force-pushed the 5044-fix-externals-dependencies branch from 8222d42 to 8dc3805 Compare October 14, 2025 19:07
@matejk
Copy link
Copy Markdown
Contributor Author

matejk commented Oct 14, 2025

Address sanitizer test fails (https://github.com/pocoproject/poco/actions/runs/18507304607/job/52739350606#step:10:7279)

=================================================================
8: ==10144==ERROR: AddressSanitizer: odr-violation (0x7fd7b3abaf20):
8:   [1] size=68 'deflate_copyright' /home/runner/work/poco/poco/dependencies/zlib/src/deflate.c:54:12 in /home/runner/work/poco/poco/cmake-build/lib/libPocoPDF.so.112
8:   [2] size=68 'deflate_copyright' /home/runner/work/poco/poco/dependencies/zlib/src/deflate.c:54:12 in /home/runner/work/poco/poco/cmake-build/lib/libPocoFoundation.so.112
8: These globals were registered at these points:
8:   [1]:
8:     #0 0x7fd7b3c5306f in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:350
8:     #1 0x7fd7b440371e  (/lib64/ld-linux-x86-64.so.2+0x571e) (BuildId: 520e05878220fb2fc6d28ff46b63b3fd5d48e763)
8:     #2 0x7fd7b4403823  (/lib64/ld-linux-x86-64.so.2+0x5823) (BuildId: 520e05878220fb2fc6d28ff46b63b3fd5d48e763)
8:     #3 0x7fd7b441d59f  (/lib64/ld-linux-x86-64.so.2+0x1f59f) (BuildId: 520e05878220fb2fc6d28ff46b63b3fd5d48e763)
8: 
8:   [2]:
8:     #0 0x7fd7b3c5306f in __asan_register_globals ../../../../src/libsanitizer/asan/asan_globals.cpp:350
8:     #1 0x7fd7b440371e  (/lib64/ld-linux-x86-64.so.2+0x571e) (BuildId: 520e05878220fb2fc6d28ff46b63b3fd5d48e763)
8:     #2 0x7fd7b4403823  (/lib64/ld-linux-x86-64.so.2+0x5823) (BuildId: 520e05878220fb2fc6d28ff46b63b3fd5d48e763)
8:     #3 0x7fd7b441d59f  (/lib64/ld-linux-x86-64.so.2+0x1f59f) (BuildId: 520e05878220fb2fc6d28ff46b63b3fd5d48e763)

@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Oct 15, 2025

Looks like zlib problem. If legitimate, should be reported upstream

@matejk
Copy link
Copy Markdown
Contributor Author

matejk commented Oct 15, 2025

Looks like zlib problem. If legitimate, should be reported upstream

Not really. The same static library is linked to Foundation and PDF shared object. and therefore there are duplicated objects of zlib library.

@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Oct 15, 2025

Ah yes, I see now. It did not manifest in make builds because there was no explicit zlib linking there. I guess add the fix for testrunner and samples and should be ok

@matejk matejk added the bug label Oct 15, 2025
@matejk matejk linked an issue Oct 15, 2025 that may be closed by this pull request
Foundation: File crashes with Windows long path prefix (\\?\) #5011
Closed
@matejk matejk removed a link to an issue Oct 15, 2025
Foundation: File crashes with Windows long path prefix (\\?\) #5011
Closed
@matejk matejk merged commit 2ec40a0 into main Oct 15, 2025
76 checks passed
@matejk matejk deleted the 5044-fix-externals-dependencies branch October 15, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build: Missing bundled dependencies

2 participants

@matejk @aleks-f