Skip to content

fix: don't remove ignored builds list on repeat install#9111

Closed
btea wants to merge 1 commit intopnpm:mainfrom
btea:fix/not-remove-ignored-builds
Closed

fix: don't remove ignored builds list on repeat install#9111
btea wants to merge 1 commit intopnpm:mainfrom
btea:fix/not-remove-ignored-builds

Conversation

@btea
Copy link
Member

@btea btea commented Feb 15, 2025

fix #9106

@btea btea requested a review from zkochan as a code owner February 15, 2025 06:06
Copy link
Member

@zkochan zkochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does the existing test work?

@btea
Copy link
Member Author

btea commented Feb 15, 2025

I also find it strange, it seems that there is a difference between the test and the actual running scenario. 🤔

zkochan added a commit that referenced this pull request Feb 16, 2025
@zkochan zkochan closed this in 0205498 Feb 16, 2025
@btea btea deleted the fix/not-remove-ignored-builds branch February 16, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

approve-builds still does not work across installs in 10.4

2 participants