approve-builds still does not work across installs in 10.4 #9106
Description
Verify latest release
- I verified that the issue exists in the latest pnpm release
pnpm version
No response
Which area(s) of pnpm are affected? (leave empty if unsure)
CLI
Link to the code that reproduces this issue or a replay of the bug
No response
Reproduction steps
- Remove
node_modulesfrom project - Run
pnpm i- Warning will be present
- Run
pnpm iagain- Warning will no longer be present
- Run
pnpm approve-builds- Output is "There are no packages awaiting approval"
Describe the Bug
Despite the change in #9083, repeated installs does not maintain the ability to approve builds.
pnpm i
Scope: all 3 workspace projects
Lockfile is up to date, resolution step is skipped
Packages: +960
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 960, reused 750, downloaded 210, added 960, done
dependencies:
+ @awt-lib/ccm-server-types 2.6.5
devDependencies:
+ @awt-lib/commitlint-config 2.2.6
+ @awt-lib/lint-staged-configs 2.0.12
+ @changesets/cli 2.27.12
+ @commitlint/cli 19.7.1
+ concurrently 9.1.2
+ cspell 8.17.3
+ lint-staged 15.4.3
+ typescript 5.7.3
╭ Warning ───────────────────────────────────────────────────────────────────────────────────╮
│ │
│ Ignored build scripts: protobufjs. │
│ Run "pnpm approve-builds" to pick which dependencies should be allowed to run scripts. │
│ │
╰────────────────────────────────────────────────────────────────────────────────────────────╯pnpm i
Scope: all 3 workspace projects
Lockfile is up to date, resolution step is skipped
Already up to datepnpm approve-builds
There are no packages awaiting approvalExpected Behavior
pnpm approve-builds and the warning should be displayed on every install.
Which Node.js version are you using?
23.7.0
Which operating systems have you used?
- macOS
- Windows
- Linux
If your OS is a Linux based, which one it is? (Include the version if relevant)
No response