[core] Improve PmdAnalysis#3822
Merged
Merged
Conversation
This interacts better with RuleSetLoader methods
509c9fa to
4d143eb
Compare
4 tasks
Generated by 🚫 Danger |
adangel
reviewed
Mar 8, 2022
adangel
approved these changes
Mar 10, 2022
adangel
added a commit
that referenced
this pull request
Mar 10, 2022
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Mar 10, 2022
[core] Improve PmdAnalysis pmd#3822
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Followup on #3785. I noticed while merging (#3819) that an incomplete PMDConfiguration could cause NPEs in PmdAnalysis::create. I'm adding tests and something to create new rulesets. I think it's easier to expose a RuleSetLoader, as we can't move all the methods of that class onto PmdAnalysis. I also checked out a change to PMDConfiguration that was already done in PMD 7 (methods there are
@DeprecatedUntil700).Of note: PmdLogger is renamed to MessageReporter (as per #3816 it's not for logging)
These changes have been incorporated into #3819 and informed by what's going on in the PMD 7 branch for better compatibility.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)