[core] Merge PmdAnalysis into pmd/7.0.x#3819
Merged
Merged
Conversation
…rectly for SObjectField.getDescribe()
Test cases use SObjectField and FieldDescribeOptions
I don't think it's worth removing it in master... Traces could admittedly be reported on a jutil.Logger, but this makes the code unreadable and it's not clear why we would do that. Other things like warnings and errors will be reported through this interface in pmd 7, so it also doesn't make sense to update their call sites.
which deals with restoring System.out/err already
adangel
approved these changes
Mar 8, 2022
adangel
left a comment
Member
There was a problem hiding this comment.
Thanks for doing the merge!
It was a bit difficult to review - but now I think I understand how GlobalAnalysisListener fits into the picture. At some point, we might add a usage sample in the java api doc.
Btw. this PR is still in draft - is it ready?
Member
Author
It is, I forgot to update it |
adangel
added a commit
that referenced
this pull request
Mar 10, 2022
[core] Merge PmdAnalysis into pmd/7.0.x #3819
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Merge master into pmd/7.0.x, as #3785 and #3692 conflict a lot. I removed most of the deprecated members of
PMD.javabecause they're impossible to maintain (processFiles is kept for compatibility with mvn pmd plugin, but it should be updated to use PmdAnalysis after PMD 6.44.0 is out).Please look at the last commits for what happened after the merge.
Note that this contains #3822.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)