Skip to content

[core] Deprecations for analysis listeners#3762

Merged
adangel merged 12 commits into
pmd:masterfrom
oowekyala:master-deprecations-for-analysis-listeners
Feb 16, 2022
Merged

[core] Deprecations for analysis listeners#3762
adangel merged 12 commits into
pmd:masterfrom
oowekyala:master-deprecations-for-analysis-listeners

Conversation

@oowekyala

@oowekyala oowekyala commented Feb 6, 2022

Copy link
Copy Markdown
Member

Describe the PR

Deprecations for #3692

Unresolved points:

  • RuleContext now has the new methods of PMD 7. Maybe we should deprecate the old AbstractRule#addViolation, but the new way to do this doesn't feel great, and is also transitional anyway (asCtx(data).addViolation(node)). I think it makes sense to keep those methods around for transition. We can mark them as @DeprecatedUntil700 in PMD 7.
  • @adangel Your comment talks about internalizing some members of the ant Formatter class. What about making the entire class internal in PMD 6? -> [core] Internalize some methods in Ant Formatter #3787
  • Maybe other things should be deprecated, like in Renderers, though I'm inclined not to do this before we're clearer about [core] Enhancements to Renderer API #3753

I looked into the designer sources and don't think the designer needs an update.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added the is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them label Feb 6, 2022
@oowekyala oowekyala added this to the 6.43.0 milestone Feb 6, 2022
@ghost

ghost commented Feb 6, 2022

Copy link
Copy Markdown
1 Message
📖 This changeset changes 87 violations,
introduces 1 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I've created #3787 for the ant formatter stuff.

@adangel adangel merged commit 1d6a1c9 into pmd:master Feb 16, 2022
@oowekyala oowekyala deleted the master-deprecations-for-analysis-listeners branch February 16, 2022 20:07
adangel added a commit to adangel/pmd that referenced this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants