Skip to content

[core] Internalize some methods in Ant Formatter #3787

@adangel

Description

@adangel
  • in net.sourceforge.pmd.ant.Formatter
    • public methods "start", "end", "getRenderer" should only be called by PMDs Task impl.
    • Ant only needs the methods "set*" and "add*" to be public.
    • public method "isNoOutputSupplied" should be internal and made package-private in PMD7.

See #3692 and #3762 for background information.

Gradle doesn't use the classes directly ( https://github.com/gradle/gradle/blob/fea8c70d22452656911c9a3ce7da1ef804665d23/subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/internal/PmdInvoker.groovy#L119) , so it shouldn't hurt.

Metadata

Metadata

Assignees

No one assigned

    Labels

    is:deprecationThe main focus is deprecating public APIs or rules, eg to make them internal, or removing them

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions