[java] InsufficientStringBufferDeclaration fix FP (#1438)#3277
Merged
oowekyala merged 5 commits intoMay 28, 2021
Merged
Conversation
Fixes false positive for initial calculated StringBuilder size. If possible, the literals are calculated. If there are method calls or variables access, then no attempt is made to calculate the initial size. Also recognized now ensureCapacity in addition to setLength. Fixes pmd#1438
Generated by 🚫 Danger |
4 tasks
Member
Author
|
I've put that one to draft, in order to fix some more problems I discovered when porting the rule to pmd7. |
- correct handling of appending a long value - correct parsing when reassigning string builder and chaining append calls - correct capacity calculation when initialized with a string constant
issue-1438-insufficientstringbufferdeclaration
When StringBuilder is used as a formal parameter, we can't know the capacity.
Member
Author
|
Ok, so that is now ready. The two new violations are valid, and the one removed violation is also ok (we can't really know the capacity in that case). |
issue-1438-insufficientstringbufferdeclaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Fixes false positive for initial calculated StringBuilder size.
If possible, the literals are calculated now. If there are method
calls or variables access, then no attempt is made to calculate
the initial size.
Also calls to ensureCapacity are recognized now in addition to setLength.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)