Skip to content

[java] Update rule InsufficientStringBufferDeclaration#3278

Merged
adangel merged 2 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-insufficientstringbufferdeclaration
Jun 25, 2021
Merged

[java] Update rule InsufficientStringBufferDeclaration#3278
adangel merged 2 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-insufficientstringbufferdeclaration

Conversation

@adangel

@adangel adangel commented May 14, 2021

Copy link
Copy Markdown
Member

Describe the PR

Updates the rule for pmd7.
Part of #2701

This contains the same changes as in #3277

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.0.0 milestone May 14, 2021
@ghost

ghost commented May 14, 2021

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 57 new violations, 0 new errors and 0 new configuration errors,
removes 134 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 37 violations,
introduces 223 new violations, 1 new errors and 0 new configuration errors,
removes 303987 violations, 8 errors and 2 configuration errors.
Full report
Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 57 new violations, 0 new errors and 0 new configuration errors,
removes 134 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 37 violations,
introduces 223 new violations, 1 new errors and 0 new configuration errors,
removes 304071 violations, 10 errors and 2 configuration errors.
Full report

Generated by 🚫 Danger

@adangel

adangel commented May 27, 2021

Copy link
Copy Markdown
Member Author

I think, that's ready as well. The test cases are the same as on master. It seems, the rule is a bit better on pmd7 (less false positives, less false negatives).

@adangel adangel marked this pull request as ready for review May 27, 2021 16:56
@adangel adangel self-assigned this Jun 25, 2021
@adangel adangel merged commit e568ad4 into pmd:pmd/7.0.x Jun 25, 2021
@adangel adangel deleted the pmd7-update-insufficientstringbufferdeclaration branch February 25, 2022 11:19
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants