[java] Java 16 support (pmd7)#3120
Merged
Merged
Conversation
The TypePattern now allows the final keyword and Annotations. Pattern variables are now only effectively final.
- Renamed ASTRecordConstructorDeclaration to ASTCompactConstructorDeclaration to align naming to JLS - ASTRecordDeclaration, ASTRecordComponentList, ASTRecordComponent, ASTRecordBody, ASTCompactConstructorDeclaration are not longer @experimental
Those cannot be used as type names.
This has been withdrawn and is not implemented in the grammar anymore.
Generated by 🚫 Danger |
oowekyala
reviewed
Feb 18, 2021
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This is the merge of #3111 into the pmd7 branch, so the merge order should be:
I've also cleaned up LanguageLevelChecker a bit.
The biggest change between pmd6 and pmd7 is the handling of modifiers for instanceof type patterns: I adjust the AST afterwards, to move the annotations to the correct place. In case of type patterns, the annotation apply to the binding variable and not to the type.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)