Skip to content

[java] Java 16 support#3111

Merged
oowekyala merged 10 commits into
pmd:masterfrom
adangel:java-16-support
Feb 19, 2021
Merged

[java] Java 16 support#3111
oowekyala merged 10 commits into
pmd:masterfrom
adangel:java-16-support

Conversation

@adangel

@adangel adangel commented Feb 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Describe the PR

Adds Java 16 support

  • Add new java language versions 16 and 16-preview. Also add in KotlinTestingDsl.kt.
  • Update asm dependency: https://search.maven.org/artifact/org.ow2.asm/asm
  • Promote "Pattern Matching for instanceof" (394) to a standard feature. Note, there might be some small changes from last preview.
  • Promote "Records" (395) to a standard feature. Note, there might be some small changes from last preview.
  • Update "Sealed Classes" (397) preview implementation. Note, there might be some small changes from last preview.
  • Remove java language version 14-preview
  • Write release notes
    • ASTTypeTestPattern renamed to ASTTypePattern
    • Not Experimental anymore (ASTVariableDeclarationId::isPatternBinding, ASTPattern, ASTTypePattern)
    • Renamed ASTRecordConstructorDeclaration to ASTCompactConstructorDeclaration to align naming to JLS
    • ASTRecordDeclaration, ASTRecordComponentList, ASTRecordComponent, ASTRecordBody, ASTCompactConstructorDeclaration are not longer Experimental
    • ...
  • Prepare merge for PMD 7 --> [java] Java 16 support (pmd7) #3120

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@adangel
[java] Add versions 16 and 16-preview, update asm
87cdd60
@adangel
[java] JEP 394: Pattern Matching for instanceof for Java16
8c755fa 
The TypePattern now allows the final keyword
and Annotations. Pattern variables are now only
effectively final.
@adangel
[java] Rename ASTTypeTestPattern -> ASTTypePattern, remove @experimental
64b501e 


With JEP 394 / Java16, this production has been renamed.
Pattern Matching for Instanceof is now a standard feature,
therefore the AST node is not experimental anymore.
@adangel adangel added this to the 6.32.0 milestone Feb 12, 2021
@ghost

ghost commented Feb 12, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown
1 Message
📖 This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala linked an issue Feb 12, 2021 that may be closed by this pull request
[core] Update beta version of asm with current version #3093
Closed
@adangel
[java] Remove more @experimental for ASTTypePattern
03731f8
@adangel
[java] JEP 395: Records for Java16
8bc26f9 
- Renamed ASTRecordConstructorDeclaration to
  ASTCompactConstructorDeclaration to align naming to JLS
- ASTRecordDeclaration, ASTRecordComponentList, ASTRecordComponent,
  ASTRecordBody, ASTCompactConstructorDeclaration are not
  longer @experimental
@adangel
[java] JEP 397: Sealed Classes (Second Preview) for Java16 Preview
3b151e3
@adangel adangel mentioned this pull request Feb 15, 2021
Closed
@adangel adangel mentioned this pull request Feb 18, 2021
Merged
4 tasks
@adangel adangel marked this pull request as ready for review February 18, 2021 15:19
@adangel adangel requested a review from oowekyala February 18, 2021 15:20
oowekyala
oowekyala approved these changes Feb 18, 2021
View reviewed changes

@oowekyala oowekyala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good :)

Comment thread pmd-java/etc/grammar/Java.jjt Outdated
Comment thread pmd-java/etc/grammar/Java.jjt
Comment thread pmd-java/src/test/java/net/sourceforge/pmd/lang/java/ast/Java16PreviewTreeDumpTest.java
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTPermitsList.java Outdated
adangel and others added 2 commits February 19, 2021 09:18
@adangel @oowekyala
Apply suggestions from code review
7187e1d 
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
@adangel
Merge branch 'master' into java-16-support
a482aa3
@oowekyala oowekyala merged commit 4ee165c into pmd:master Feb 19, 2021
@adangel adangel deleted the java-16-support branch February 21, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oowekyala oowekyala oowekyala approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.32.0

Development

Successfully merging this pull request may close these issues.

[core] Update beta version of asm with current version [java] Support JDK 16

2 participants

@adangel @oowekyala