Skip to content

[all] Deprecations for #2706 and #2661#2720

Merged
oowekyala merged 4 commits into
pmd:masterfrom
adangel:deprecations-for-2661-and-2706
Aug 23, 2020
Merged

[all] Deprecations for #2706 and #2661#2720
oowekyala merged 4 commits into
pmd:masterfrom
adangel:deprecations-for-2661-and-2706

Conversation

@adangel

@adangel adangel commented Aug 22, 2020

Copy link
Copy Markdown
Member

Describe the PR

This adds the deprecations for pmd6:

Note: We have JavaParserVisitorReducedAdapter on pmd6 but deleted it already on pmd7. But it is not deprecated on master: https://github.com/pmd/pmd/blob/master/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/JavaParserVisitorReducedAdapter.java

Should we deprecate it as well? We have some usages in the code base...

Related issues

  • Fixes

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@adangel adangel added the is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them label Aug 22, 2020
@adangel adangel added this to the 6.27.0 milestone Aug 22, 2020
@oowekyala oowekyala mentioned this pull request Aug 22, 2020
Merged
6 tasks
@oowekyala

oowekyala commented Aug 22, 2020

Copy link
Copy Markdown
Member

Thanks for taking this on! I think it's ok to deprecate the java visitor, I wouldn't expect it to be used widely outside of here anyway. Usages are easy to port, maybe, that's already done on the PMD 7 branch if the class was already deleted

@ghost

ghost commented Aug 22, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
1 Message
📖 This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
✅ No java rules are changed!

Generated by 🚫 Danger

@adangel

adangel commented Aug 22, 2020

Copy link
Copy Markdown
Member Author

FYI - I've deprecated now also JavaParserVisitorReducedAdapter.

I've milestoned this PR to 6.27.0, but it does not necessarily done - could wait for 6.28.0

@oowekyala

oowekyala commented Aug 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

I think it's better to merge it soon, as it looks ready. #2714 will also cause some conflicts with #2706. I think it would be best for #2706 to be merged asap. The merge order would be

When all of that is in 7.0.x, the merge into java grammar merge is going to be a pain. But at least we only have to do it once. I already think, I should not have merged #2714 into java-grammar on its own.

I'm going to do this today.

@oowekyala oowekyala self-assigned this Aug 23, 2020
@oowekyala oowekyala merged commit f7a7801 into pmd:master Aug 23, 2020
@adangel adangel deleted the deprecations-for-2661-and-2706 branch August 23, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oowekyala oowekyala

Labels

is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them

Projects

None yet

Milestone

6.27.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adangel @oowekyala