[javascript] Generic visitor for JS#2707
Merged
Merged
Conversation
Generated by 🚫 Danger |
10 tasks
adangel
reviewed
Aug 22, 2020
| /** | ||
| * Accept the visitor. * | ||
| */ | ||
| Object jjtAccept(EcmascriptParserVisitor visitor, Object data); |
Member
There was a problem hiding this comment.
hm... we still have these methods on master. But I don't think it makes sense to deprecate it there...
Member
Author
There was a problem hiding this comment.
Ah good catch, I think for the other languages this was @DeprecatedUntil700, with a default impl that calls acceptVisitor
adangel
approved these changes
Aug 22, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Implement #880 for JS
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)