Update pmd-eclipse-imports.importorder#76
Conversation
adangel
left a comment
There was a problem hiding this comment.
Thanks!
For reference: pmd/pmd#5875 (comment)
Similar fix like pmd#76
|
this will be wrong anytime soon again, as there is no one, to check on this and prevent. Simply having proper tooling, like some random tool named spotless, that really applies the config every time, would instantly tell if there is any delta. |
Why do you think that? |
|
What has changed? Nothing. It was possible to impose delta, so it is right now. If there is no tool applying this all over and over it will be wrong again. Ether let check understand and enforce the this configuration or use spot as it is the same. Tooling needs to enforce the standards or they simply don’t exist. Sent from my iPhoneOn 4 Jul 2025, at 20:00, Andreas Dangel ***@***.***> wrote:adangel left a comment (pmd/build-tools#76)
this will be wrong anytime soon again, as there is no one, to check on this and prevent.
Why do you think that?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
The configuration for eclipse was wrong, but the code not (no wrong import orders committed).
There is. The import order is enforced by checkstyle and this runs with maven verify phase. So I don't understand what your problem is. This eclipse config was wrong, yes, but this doesn't matter: checkstyle would still have caught this with a build failure. |
true. Then its only UX we could improve, by shifting the config into convent. |
having config applied turns out to be violating check config.
with this its in one block like commited.
fix gap:
importOrderwithMaven Spotless Pluginpmd#5776