now its up to you how to continue:

• update custom formation config which seems outdated
• or simply go with some big players default like google or palantir. Spotless offers it all.

@adangel @oowekyala what do you think? is pmd build already fixing itself like in maven?

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.

Regression Tester Report

(comment created at 2025-06-20 14:13:41+00:00 for 757a818)

adapt

yes we on the same page. This is kind of an issue itself, as new dev´s should use this config as setup.

Is there any chance to simple apply convention cover configuration and go with palantir block style? This would make things easy as relying on big players.

https://github.com/palantir/palantir-java-format

Adapting the config to checkstyle can be intense.

This causes countless conflicts with main and with other in-flight PRs. Please adapt the formatter config to minimize changes.

if config is updated it should be no problem. thats a good example why migration is useful. Replace 5 years ago cost of carry and apply once.

https://docs.pmd-code.org/latest/pmd_devdocs_contributing.html#code-style
https://github.com/pmd/build-tools/tree/main/eclipse

please check on your system and give format on your behalf.

Current checkstyle config is pretty huge demanding cost of carry.

Might be simple to apply convention over configuration what PMD itself is about. Giving end on discussion and opinion, just going with common default crafted by community.

Only effort is to choose which one.

googleJavaFormat and palantirJavaFormat seem both justiciable. At the end its like everything a random implementation detail when aligned on some norm.

trying to migrate https://github.com/pmd/build-tools/blob/main/src/main/resources/net/sourceforge/pmd/pmd-checkstyle-config.xml to eclipse format.

current flaws:

inconsistent (double) white lines:

why 2 lines? where is checkstyle?

whitespaces:

• whitespaces before is broken anyways pretty hard, and they dont seem to care that much.
• Issue #16781: NoWhitespaceBefore blind spot resulting in high failure rate checkstyle/checkstyle#16781

• pmd/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/internal/JavaAstProcessor.java

  Line 154 in ad71cb5

  ASTCompilationUnit ast) {

• https://github.com/pmd/pmd/blob/ad71cb5a4a670bdb9d6b53d90476d0510dc14618/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/internal/JavaAstProcessor.java#L161C43-L161C44

no need to maintain limited tool check, imho. i like check very much, but spot is obviously superior.

facing all the issues, is thre any chance to really consider migration? @adangel

build pass 👍 thank you.

Please discuss these changes in #5651.

blocking:

• [java] Fix #5837: New Rule: OverrideBothEqualsAndHashCodeOnComparable #5856 (comment)

Please discuss these changes in #5651.

assuming approach is complain, as not contradiction encountered, we could reopen this to fix import burden and focus on features instead of being blocked by automatable cosmetics.