Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Initial commit of R package providing dash-table functionality#442

Merged
rpkyle merged 14 commits intomasterfrom
R
Jun 4, 2019
Merged

Initial commit of R package providing dash-table functionality#442
rpkyle merged 14 commits intomasterfrom
R

Conversation

@rpkyle
Copy link
Copy Markdown
Contributor

@rpkyle rpkyle commented May 26, 2019 •
edited
Loading

This PR proposes to include an R package providing support for the DataTable component.

The command used to build this package was

dash-generate-components ./src/dash-table/dash dash_table --r-prefix="dash"

dashTable was built using an updated version of the package generation code that incorporates documentation for nested props found in the source JavaScript, which previously were not included in the dashDataTable.Rd help file.

In brief, generating documentation for PropTypes.exact entries is now possible.

A helper function is also proposed which simplifies passing in data.frames in R as inputs to data, similar to the .to_dict() method in pandas:

dash-table/R/df_to_list.R

Lines 1 to 8 in ae03f11

df_to_list <- function(df) {
if(!(is.data.frame(df)))
stop("df_to_list requires a data.frame object; please verify that df is of the correct type.")
setNames(lapply(split(df, seq(nrow(df))),
FUN = function (x) {
as.list(x)
}), NULL)
}

Closes #456.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 26, 2019 15:06 Inactive
@rpkyle rpkyle changed the title Initial commit of R package providing dash-table functionality Initial commit of R package providing dash-table functionality May 26, 2019
@rpkyle rpkyle self-assigned this May 26, 2019
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 26, 2019 15:07 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 26, 2019 15:11 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 26, 2019 15:15 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 28, 2019 13:14 Inactive
@alexcjohnson alexcjohnson mentioned this pull request May 28, 2019
Closed
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 30, 2019 22:49 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 30, 2019 23:04 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 30, 2019 23:14 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 30, 2019 23:28 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 30, 2019 23:35 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 May 31, 2019 14:29 Inactive
@rpkyle
Copy link
Copy Markdown
Contributor Author

rpkyle commented May 31, 2019

Noticed a Percy test indicated that "dash green" should appear, cell border colour was actually "dashed blue." Chatted with @Marc-Andre-Rivet, now fixed in 81ec923.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 June 1, 2019 22:42 Inactive
alexcjohnson
alexcjohnson approved these changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 💃

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-442 June 4, 2019 03:40 Inactive
@rpkyle rpkyle merged commit 6d49d2d into master Jun 4, 2019
@rpkyle rpkyle deleted the R branch June 4, 2019 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Marc-Andre-Rivet Marc-Andre-Rivet Awaiting requested review from Marc-Andre-Rivet

1 more reviewer

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rpkyle rpkyle

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

R package support for dash-table

6 participants

@rpkyle @alexcjohnson @chriddyp @alinastarkov @Marc-Andre-Rivet @nicolaskruchten