Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Fix monorepo build#443

Merged
Marc-Andre-Rivet merged 5 commits intomasterfrom
dash-table-build-fix
May 28, 2019
Merged

Fix monorepo build#443
Marc-Andre-Rivet merged 5 commits intomasterfrom
dash-table-build-fix

Conversation

@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor

No description provided.

@chriddyp chriddyp temporarily deployed to dash-table-review-pr-443 May 27, 2019 18:17 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-443 May 27, 2019 18:31 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-443 May 27, 2019 18:37 Inactive
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-443 May 28, 2019 12:52 Inactive
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title leap of faith sort of deal Fix monorepo build May 28, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review May 28, 2019 13:17
Copy link
Copy Markdown
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byronz 's comment about shallow cloning is relevant here too, but non-blocking. Looks great, thanks for cleaning up some of the remaining v0/v1 stuff. 💃

@Marc-Andre-Rivet
Copy link
Copy Markdown
Contributor Author

As per comment, updating to shallow clone everywhere.

@Marc-Andre-Rivet Marc-Andre-Rivet merged commit ad791a7 into master May 28, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the dash-table-build-fix branch May 28, 2019 15:32
rpkyle pushed a commit that referenced this pull request May 30, 2019
monorepo changes + shallow clone + v0/v1 clean up
rpkyle added a commit that referenced this pull request Jun 4, 2019
* 🎉 initial commit of dashTable R package

* border is none if not define

* test cases for css border overwrite bugs

* edit CHANGELOG.md

* Update CHANGELOG.md

Co-Authored-By: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>

* Fix monorepo build (#443)

monorepo changes + shallow clone + v0/v1 clean up

* Create FUNDING.yml

* 📝 correct "dash green" to "dashed blue"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants