This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 434 - Fix css overwritten table border bugs #439
Merged
alinastarkov merged 6 commits intomasterfrom May 28, 2019
Merged
Conversation
Marc-Andre-Rivet
suggested changes
May 24, 2019
Contributor
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
This is looking good.
Missing items:
- Branch needs to be updated
- Add a
### Fixedentry in the CHANGELOG succinctly describing the issue and linking to this PR or the issue
Marc-Andre-Rivet
suggested changes
May 27, 2019
Contributor
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
The visual tests are looking good.
Python 3.6 build fails with:
> dash-table@3.7.0 private::build:generate-classes /home/circleci/project
> python -c "import dash; dash.development.component_loader.generate_classes('dash_table', 'dash_table/metadata.json')"
Traceback (most recent call last):
File "<string>", line 1, in <module>
AttributeError: module 'dash' has no attribute 'development'
This is because the dash dependency does not match the build expectations anymore, updating the branch should fix that.
Co-Authored-By: Marc-André Rivet <Marc-Andre-Rivet@users.noreply.github.com>
Marc-Andre-Rivet
approved these changes
May 28, 2019
Contributor
There was a problem hiding this comment.
💃 This looks good and the tests cover lots of ground. Just need to wait for the branch to become sane again & update. #443
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #434