Refactored the way Play access config#4093
Merged
richdougherty merged 1 commit intoplayframework:masterfrom Mar 18, 2015
Merged
Refactored the way Play access config#4093richdougherty merged 1 commit intoplayframework:masterfrom
richdougherty merged 1 commit intoplayframework:masterfrom
Conversation
Member
jroper
commented
Mar 18, 2015
- Introduced PlayConfig helper which is more suited to idiomatic use of Typesafe config
- Migrated a number of config options from old paths to new paths
- Removed "modules" from configuration keys
- Moved more settings to reference.conf
- Introduced idiom of using "null" rather than blank or no setting for default values.
* Introduced PlayConfig helper which is more suited to idiomatic use of Typesafe config * Migrated a number of config options from old paths to new paths * Removed "modules" from configuration keys * Moved more settings to reference.conf * Introduced idiom of using "null" rather than blank or no setting for default values.
Merged
Member
There was a problem hiding this comment.
Maybe mention that ConfigException.Missing will still be thrown for entries that don't have a null value? I found it a bit hard to understand until I read the Typesafe Config docs and looked at PlayConfigSpec.
Member
Author
There was a problem hiding this comment.
Will do in another pull request that I'm currently working on.
richdougherty
added a commit
that referenced
this pull request
Mar 18, 2015
Refactored the way Play access config
Member
|
@jroper, I had a minor suggestion for an extra comment but I'm merging this PR now because I know it's blocking you. |
Member
|
👍 Overall, a nice improvement. |
Contributor
|
for the module configuration,how about ,using the annotation,like @Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
@Inherited
public @interface ModuleConfigPath{
String path();
}and then something like this |
rtyley
added a commit
to guardian/atom-workshop
that referenced
this pull request
Jan 26, 2024
Prompted by this error message in the logs: application.conf @ file:/usr/share/atom-workshop/conf/application.conf: 9: parsers.text.maxLength is deprecated, use play.http.parser.maxMemoryBuffer instead Apparently the parsers.text.maxLength property has been deprecated since Play 2.4 and playframework/playframework#4093 https://www.playframework.com/documentation/2.9.x/ScalaBodyParsers#Max-content-length In atom-workshop, the increased size was set to allow bigger chart atoms: #272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.