Conversation
jonathonherbert
approved these changes
Apr 20, 2020
Contributor
jonathonherbert
left a comment
There was a problem hiding this comment.
👍 hopefully a small one, after all!
Contributor
Author
|
thanks @jonathonherbert |
rtyley
added a commit
that referenced
this pull request
Jan 26, 2024
Prompted by this error message in the logs: application.conf @ file:/usr/share/atom-workshop/conf/application.conf: 9: parsers.text.maxLength is deprecated, use play.http.parser.maxMemoryBuffer instead Apparently the parsers.text.maxLength property has been deprecated since Play 2.4 and playframework/playframework#4093 https://www.playframework.com/documentation/2.9.x/ScalaBodyParsers#Max-content-length In atom-workshop, the increased size was set to allow bigger chart atoms: #272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some chart atoms were failing to save because the amount of data used in them (eg datasets of 1000+ lines) was too big. PUT requests to save the atom were failing with a
413 Error: Request Entity Too Large.What has changed
This PR increases the size of requests accepted by the Play app - up from the default
100kBto200kB.The test dataset that was failing - the discrete line in this spreadsheet, had a body size that was
104kBlarge.See documentation for this property here: https://www.playframework.com/documentation/2.0.x/ScalaBodyParsers#Max-content-length
To Test
Try making a discrete line chart using the data the discrete line in this spreadsheet