Merged
Conversation
Member
mkurz
commented
May 12, 2023
- Guice 6.0.0 & 7.0.0 Release google/guice#1742
- https://github.com/google/guice/wiki/Guice600
6 tasks
Member
|
Hi, @mkurz! Should we think about migrate to Guice 7 for 2.9? 🤔 |
Member
|
Sorry, now I see #11792 👍 |
rtyley
added a commit
to guardian/atom-maker
that referenced
this pull request
Jan 17, 2024
After #93 we found that unfortunately the Release workflow failed while running the tests: * The Release workflow uses Java 17 for all builds * The Atom Maker library uses Play with Guice for Dependency Injection * Guice gained Java 17 & 21 support with Guice v6: https://github.com/google/guice/wiki/Guice600 * Play only updated to Guice v6 (and gained general Java 17 support) with Play v2.9: playframework/playframework#11808 playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
rtyley
added a commit
to guardian/atom-maker
that referenced
this pull request
Jan 17, 2024
After #93 we found that unfortunately the Release workflow failed while running the tests: * The Release workflow uses Java 17 for all builds * The Atom Maker library uses Play with Guice for Dependency Injection * Guice gained Java 17 & 21 support with Guice v6: https://github.com/google/guice/wiki/Guice600 * Play only updated to Guice v6 (and gained general Java 17 support) with Play v2.9: playframework/playframework#11808 playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
rtyley
added a commit
to guardian/atom-maker
that referenced
this pull request
Jan 18, 2024
After #93 we found that unfortunately the Release workflow failed while running the tests: * The Release workflow uses Java 17 for all builds * The Atom Maker library uses Play with Guice for Dependency Injection * Guice gained Java 17 & 21 support with Guice v6: https://github.com/google/guice/wiki/Guice600 * Play only updated to Guice v6 (and gained general Java 17 support) with Play v2.9: playframework/playframework#11808 playframework/playframework@10ca54d#diff-3dc52110c1c1c453c2e9740ac58fe7e90d53121875a034ef3109c34ab030c29e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.