Guice 7 + switch to Jakarta Dependency Injection#11792
Merged
mkurz merged 8 commits intoplayframework:mainfrom Jan 24, 2025
Merged
Guice 7 + switch to Jakarta Dependency Injection#11792mkurz merged 8 commits intoplayframework:mainfrom
mkurz merged 8 commits intoplayframework:mainfrom
Conversation
Member
Author
|
The two scripted tests that fail, but that's because they depend on scalatestplus-play / play-ws which didn't switch to Jakarta inject yet of course. I built them locally with Jakarta and ran all the scripted tests with success afterwards. Nice. |
Merged
c8e87c3 to
3f0115b
Compare
This was referenced May 6, 2024
Contributor
|
@mkurz: is there something specific blocking this work? |
|
Ping 👋🏼 |
b51f23b to
d855505
Compare
ihostage
reviewed
Jan 24, 2025
|
|
||
| ```scala | ||
| import javax.inject.Inject | ||
| import jakarta.inject.Inject |
Member
There was a problem hiding this comment.
I think the changes in documentation/manual/releases/** should be reverted 😉
003f78b to
6acde5b
Compare
…ta.inject-api dep)" This reverts commit 558bf8b. Gradle hardcodes javax.inject, we can just wait until they support jakarta inject: - gradle/gradle#20183 - gradle/gradle#31135 - https://github.com/gradle/gradle/blob/v8.12.1/platforms/core-configuration/model-core/src/main/java/org/gradle/internal/instantiation/generator/InjectUtil.java#L43-L58
...which itself depends on Play, and those Play artifacts that scalatestplus-play pulls in still, of course, use javax.inject, because we have not released Play artifacts that use jakarta.inject yet... So this is a catch22 which can only be solved by disabling these 3 tests, release Play artifacts that switched to jakarta, upgrade scalatestplus-play to make use oft them and then enable the tests again with upgraded scalatestplus-play...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.