Skip to content

Fix flaky tests#1229

Merged
mkurz merged 1 commit intoplayframework:mainfrom
mkurz:fix_flaky_tests
Oct 10, 2025
Merged

Fix flaky tests#1229
mkurz merged 1 commit intoplayframework:mainfrom
mkurz:fix_flaky_tests

Conversation

@mkurz
Copy link
Member

@mkurz mkurz commented Oct 10, 2025

Should hopefully avoid failures like

[error]       x preserve a single trailing zero decimal from multiple of ten with preserveZeroDecimal=true (25 ms)
[error]        '10' != '10.0' (JsonSpec.scala:362)

It's always another test that fails. Likely because each tests sets the static config:

def withJsonConfig[T](jsonConfig: JsonConfig)(f: () => T) = {
try {
JacksonJson.setConfig(jsonConfig)
f.apply()
} catch {
case err: Throwable => throw err
} finally {
JacksonJson.setConfig(JsonConfig.settings)
}
}

🤞

Last failing workflow: https://github.com/playframework/play-json/actions/runs/18400241471/job/52429804535

@mkurz
Copy link
Member Author

mkurz commented Oct 10, 2025

@Mergifyio backport 2.10.x 3.0.x

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

backport 2.10.x 3.0.x

✅ Backports have been created

Details

@mkurz mkurz merged commit 84b6377 into playframework:main Oct 10, 2025
14 checks passed
@mkurz mkurz deleted the fix_flaky_tests branch October 10, 2025 09:29
mergify bot pushed a commit that referenced this pull request Oct 10, 2025
(cherry picked from commit 84b6377)
mergify bot pushed a commit that referenced this pull request Oct 10, 2025
(cherry picked from commit 84b6377)
mkurz added a commit that referenced this pull request Oct 10, 2025
(cherry picked from commit 84b6377)

Co-authored-by: Matthias Kurz <m.kurz@irregular.at>
mkurz added a commit that referenced this pull request Oct 10, 2025
(cherry picked from commit 84b6377)

Co-authored-by: Matthias Kurz <m.kurz@irregular.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant