Skip to content

[2.10.x] Fix flaky tests (backport #1229) by @mkurz#1230

Merged
mkurz merged 1 commit into2.10.xfrom
mergify/bp/2.10.x/pr-1229
Oct 10, 2025
Merged

[2.10.x] Fix flaky tests (backport #1229) by @mkurz#1230
mkurz merged 1 commit into2.10.xfrom
mergify/bp/2.10.x/pr-1229

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 10, 2025

Should hopefully avoid failures like

[error]       x preserve a single trailing zero decimal from multiple of ten with preserveZeroDecimal=true (25 ms)
[error]        '10' != '10.0' (JsonSpec.scala:362)

It's always another test that fails. Likely because each tests sets the static config:

def withJsonConfig[T](jsonConfig: JsonConfig)(f: () => T) = {
try {
JacksonJson.setConfig(jsonConfig)
f.apply()
} catch {
case err: Throwable => throw err
} finally {
JacksonJson.setConfig(JsonConfig.settings)
}
}

🤞

Last failing workflow: https://github.com/playframework/play-json/actions/runs/18400241471/job/52429804535


This is an automatic backport of pull request #1229 done by Mergify.

(cherry picked from commit 84b6377)
@mergify mergify bot mentioned this pull request Oct 10, 2025
@mkurz mkurz merged commit c29c8e0 into 2.10.x Oct 10, 2025
6 checks passed
@mkurz mkurz deleted the mergify/bp/2.10.x/pr-1229 branch October 10, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant