add new sig isTrueWithNull and isFalseWithNull#177
Merged
XuHuaiyu merged 8 commits intopingcap:masterfrom Apr 17, 2020
Merged
Conversation
…ull/ isFalseWithNull
Contributor
Author
|
@breeswish @XuHuaiyu PTAL |
breezewish
reviewed
Apr 17, 2020
proto/expression.proto
Outdated
| LeftShift = 3129; | ||
| RightShift = 3130; | ||
| IntIsTrueWithNull = 3142; | ||
| RealIsTrueWithNull = 3143; |
breezewish
approved these changes
Apr 17, 2020
This was referenced Apr 21, 2020
hanfei1991
pushed a commit
to hanfei1991/tipb
that referenced
this pull request
May 28, 2020
hanfei1991
added a commit
that referenced
this pull request
Jun 18, 2020
* add join proto Signed-off-by: Fei Han <hanfei19910905@gmail.com> fix adjust join proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto add key range for table scan change go code * *: update dependency (#173) update protobuf-build to 0.11 and prost to 0.6 update ci image Signed-off-by: Jay Lee <BusyJayLee@gmail.com> * Separate signatures for ModInt PCP#13978 (#175) Signed-off-by: fredchenbj <cfworking@163.com> * add IsTrueOrFalseMetadata (#176) * add new sig `isTrueWithNull` and `isFalseWithNull` (#177) * make broadcast join backward compatible * fix rust ci * fix make go * add probe/build field types in join * Update proto/executor.proto Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com> * add comments Co-authored-by: Jay <BusyJay@users.noreply.github.com> Co-authored-by: Fu Chen <cfworking@163.com> Co-authored-by: Chengpeng Yan <41809508+Reminiscent@users.noreply.github.com> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the change for #176
Add new sig
isTrueWithNullandisFalseWithNull