Conversation
|
@XuHuaiyu @breeswish PTAL |
proto/metadata.proto
Outdated
| optional bytes consts = 2; | ||
| } | ||
|
|
||
| message KeepNullMetadata { |
There was a problem hiding this comment.
prefer to name it for functions, i.e. IsTrueMetadata
There was a problem hiding this comment.
This name is to be consistent with a similar implementation before. We use the parameters in the expression variable to name instead of the name of the expression. Besides, keepNull can be used in more expression, such as isTrue , isFalse. What's your opinion? @breeswish
There was a problem hiding this comment.
InUnionMetadata was named as InUnion because not all cast functions uses it so that it is not suitable to name it CastMetadata.
If multiple (but not many) functions shares it, prefer to duplicate it, like IsTrueMetadata and IsFalseMetadata. The reason of the duplication is that each SIG can only associate with one metadata, so that when more properties are needed in future, it can be added easily.
There was a problem hiding this comment.
Got it. @breeswish PTAL
* add join proto Signed-off-by: Fei Han <hanfei19910905@gmail.com> fix adjust join proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto refine proto add key range for table scan change go code * *: update dependency (#173) update protobuf-build to 0.11 and prost to 0.6 update ci image Signed-off-by: Jay Lee <BusyJayLee@gmail.com> * Separate signatures for ModInt PCP#13978 (#175) Signed-off-by: fredchenbj <cfworking@163.com> * add IsTrueOrFalseMetadata (#176) * add new sig `isTrueWithNull` and `isFalseWithNull` (#177) * make broadcast join backward compatible * fix rust ci * fix make go * add probe/build field types in join * Update proto/executor.proto Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com> * add comments Co-authored-by: Jay <BusyJay@users.noreply.github.com> Co-authored-by: Fu Chen <cfworking@163.com> Co-authored-by: Chengpeng Yan <41809508+Reminiscent@users.noreply.github.com> Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn> Co-authored-by: Feng Liyuan <darktemplar.f@gmail.com>
Related to: pingcap/tidb#15926